> On March 8, 2016, 9:57 p.m., Ben Mahler wrote: > > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp, > > line 55 > > <https://reviews.apache.org/r/44363/diff/1/?file=1280272#file1280272line55> > > > > No periods at the end of error / failure messages, can you do a sweep > > here?
Done. > On March 8, 2016, 9:57 p.m., Ben Mahler wrote: > > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp, > > line 19 > > <https://reviews.apache.org/r/44363/diff/1/?file=1280271#file1280271line19> > > > > Only one newline here Done. > On March 8, 2016, 9:57 p.m., Ben Mahler wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 220-222 > > <https://reviews.apache.org/r/44363/diff/1/?file=1280270#file1280270line220> > > > > Can we get some feedback from Jie about the naming we've chosen here? Haven't talked to him yet, but I wanted to get the newest revisions out pending this since it percolates through everything anyway. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44363/#review122600 ----------------------------------------------------------- On March 14, 2016, 7:37 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44363/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 7:37 a.m.) > > > Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. > > > Bugs: MESOS-4623 > https://issues.apache.org/jira/browse/MESOS-4623 > > > Repository: mesos > > > Description > ------- > > This is the first isolator to fall under the category of cgroup > devices. However, we do not yet have a generic cgroup device isolator > (nor will we in the very near future). As such, I have preemptively > created the nvidia gpu isolator in the directory hierarchy under the > path: > > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/ > > in order to easily allow them to fall under the category of gpu > devices later on. > > In this stub implementation, initialization of the agent will > fail if the nvidia gpu isolator is enabled via the agent --isolation > flag. That is --isolation="cgroups/devices/gpu/nvidia". In a > subsequent commit we will fill in the guts to actually enable the > proper isolation. > > The flags documentation has been udpated accordingly. > > > Diffs > ----- > > docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b > src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 > src/slave/containerizer/mesos/containerizer.cpp > af3ff5750649497d8852b4761c78d4cae5455a02 > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp > PRE-CREATION > src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd > > Diff: https://reviews.apache.org/r/44363/diff/ > > > Testing > ------- > > Running `make -j` doesn't cause any compilation errors. > > A forthcoming unit test exercises the isolator path even with these stubs. > > > Thanks, > > Kevin Klues > >
