----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review122760 -----------------------------------------------------------
Pass over the header file for questions + review of the API. src/tests/cluster.hpp (line 82) <https://reviews.apache.org/r/43613/#comment184861> Why do we need to return `Try<process::Owned<Master>>` as opposed to `Try<Master>`? src/tests/cluster.hpp (line 93) <https://reviews.apache.org/r/43613/#comment184863> We're storing a `process::Owned<MasterDetector>`, but returning an instance of `process::Owned<MasterDetector>` here. This probably only works because `Owned` is implemented as `Shared` currently. This should either be `Shared`, or something like `const MasterDetector&`/`const MasterDetector*`. src/tests/cluster.hpp (line 102) <https://reviews.apache.org/r/43613/#comment184857> `Master() = default;` src/tests/cluster.hpp (line 108) <https://reviews.apache.org/r/43613/#comment184856> The zookeeper setup is for multi-master setup, right? Before, we had a zookeeper url per-`Masters`, now we have it per-`Master`. Is the idea to simply store duplicates instead? src/tests/cluster.hpp (line 109) <https://reviews.apache.org/r/43613/#comment184855> `Files` used to be at the cluster level, now it is at a per-`Master` level. Could you explain briefly what this is used for and why it's ok to do this? src/tests/cluster.hpp (lines 186 - 187) <https://reviews.apache.org/r/43613/#comment184864> Could you explain why this used to be owned, but now is non-owned? - Michael Park On March 2, 2016, 9:45 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43613/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 9:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Artem > Harutyunyan, and Michael Park. > > > Bugs: MESOS-4633 and MESOS-4634 > https://issues.apache.org/jira/browse/MESOS-4633 > https://issues.apache.org/jira/browse/MESOS-4634 > > > Repository: mesos > > > Description > ------- > > Major rewrite of the `tests/cluster` helpers. This strongly ties the scope > of test objects to the test body. > > Changes the `Cluster` class into two RAII objects (`Master` and `Slave`). > The `Slave` object performs cleanup originally found in > `cluster::Slave::stop`. `cluster::Master::start` and `cluster::Slave::start` > were changed to factory methods. > > > Diffs > ----- > > src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 > src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 > > Diff: https://reviews.apache.org/r/43613/diff/ > > > Testing > ------- > > Tests are run at the end of this review chain. > > > Thanks, > > Joseph Wu > >
