----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review122886 -----------------------------------------------------------
Can you add some tests for these endpoints that show that hitting them with a bad credential will fail with status `Unauthorized`? See `TeardownTest.TeardownEndpointBadCredentials` or `PersistentVolumeEndpointsTest.BadCredentials`. src/tests/master_maintenance_tests.cpp (line 129) <https://reviews.apache.org/r/44186/#comment184979> Why set this to false and then still createBasicAuthHeaders for these tests? Why can't we keep this at `true`? - Adam B On March 9, 2016, 9:56 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44186/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 9:56 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Greg Mann. > > > Bugs: MESOS-4844 > https://issues.apache.org/jira/browse/MESOS-4844 > > > Repository: mesos > > > Description > ------- > > Added Authentication to master http endpoints (except version, health, > redirect, scheduler). > > > Diffs > ----- > > src/master/http.cpp 5e9e28e904ba0045ee27eb828f47231632a91d74 > src/master/master.hpp 52b2ceab21bc8cccea1d57385c3f1e14e31f3bce > src/master/master.cpp 2be954d04ab9ba329bac95d815637caf557339cc > src/tests/fault_tolerance_tests.cpp > f2b8dba809518cf716b2b5a7a6a8a5fe62e57646 > src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a > src/tests/master_maintenance_tests.cpp > 3faa8136cf57276295553910319480028f433e4c > src/tests/master_tests.cpp 36595772b34bcb8d37dbc74d247bdf4614f10150 > src/tests/persistent_volume_endpoints_tests.cpp > 81185a161498394020a27f1f5bf747bac5425f43 > src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da > src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 > src/tests/status_update_manager_tests.cpp > d64d3b8c96270478f6b681c038de77c3a9eb68fe > > Diff: https://reviews.apache.org/r/44186/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
