-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43911/#review122958
-----------------------------------------------------------




src/slave/http.cpp (lines 89 - 105)
<https://reviews.apache.org/r/43911/#comment185052>

    This needs to be defined in the namespace that `TaskInfo` is defined, that 
is, in the `mesos` namespace.



src/slave/http.cpp (line 97)
<https://reviews.apache.org/r/43911/#comment185054>

    If we were using `model` before, we need to maintain that.
    
    We have a `json` defined for `CommandInfo` in `src/common/http.cpp`, we 
should add the declaration `void json(JSON::ObjectWriter* writer, const 
CommandInfo& command);` to `src/common/http.hpp`.
    
    We can then use it like this:
    
    ```
    writer->field("command", task.command());
    ```



src/slave/http.cpp (line 125)
<https://reviews.apache.org/r/43911/#comment185055>

    Same as above, since we were using `model` before, we need to maintain 
this. We just need to remove the `JSON::Protobuf` here.
    
    ```
    writer->element(task);
    ```



src/slave/http.cpp (line 493)
<https://reviews.apache.org/r/43911/#comment185056>

    Curious as to why we added a newline here.



src/slave/http.cpp (line 497)
<https://reviews.apache.org/r/43911/#comment185057>

    Same here, why the newline?


- Michael Park


On Feb. 29, 2016, 7:01 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43911/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `/state` agent endpoint to use jsonify.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
> 
> Diff: https://reviews.apache.org/r/43911/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to