> On March 10, 2016, 7 p.m., Michael Park wrote: > > src/slave/http.cpp, line 105 > > <https://reviews.apache.org/r/43911/diff/4/?file=1273735#file1273735line105> > > > > If we were using `model` before, we need to maintain that. > > > > We have a `json` defined for `CommandInfo` in `src/common/http.cpp`, we > > should add the declaration `void json(JSON::ObjectWriter* writer, const > > CommandInfo& command);` to `src/common/http.hpp`. > > > > We can then use it like this: > > > > ``` > > writer->field("command", task.command()); > > ```
This does not seem to have been addressed. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/#review122958 ----------------------------------------------------------- On March 17, 2016, 9:33 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43911/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 9:33 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > Updated `/state` agent endpoint to use jsonify. > > > Diffs > ----- > > src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e > > Diff: https://reviews.apache.org/r/43911/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
