----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review123025 -----------------------------------------------------------
Fix it, then Ship it! src/docker/docker.cpp (lines 306 - 307) <https://reviews.apache.org/r/44531/#comment185158> s/networkModeValue/networkMode/ src/docker/docker.cpp (lines 311 - 312) <https://reviews.apache.org/r/44531/#comment185159> Can you make this less jagged: ``` VLOG(1) << "Unable to detect HostConfig.NetworkMode, " << "attempting deprecated IP field"; ``` src/docker/docker.cpp (line 315) <https://reviews.apache.org/r/44531/#comment185161> Can you add a NOTE about the fact that we rely on docker containerizer to always set `--net` (basically the discussion in the review thread) src/docker/docker.cpp (line 316) <https://reviews.apache.org/r/44531/#comment185160> you can use networkMode->value here src/docker/docker.cpp (lines 336 - 341) <https://reviews.apache.org/r/44531/#comment185162> To be consistent, maybe just do `if (!ipAddressValue.isSome())` here as well? - Jie Yu On March 8, 2016, 10:54 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44531/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 10:54 p.m.) > > > Review request for mesos, Dan Osborne, Jie Yu, and Travis Hegner. > > > Bugs: MESOS-4370 > https://issues.apache.org/jira/browse/MESOS-4370 > > > Repository: mesos > > > Description > ------- > > Fixed parsing network ip address with docker. > > > Diffs > ----- > > src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 > > Diff: https://reviews.apache.org/r/44531/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
