----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44690/#review123085 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On March 11, 2016, 3:11 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44690/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 3:11 a.m.) > > > Review request for mesos, Ben Mahler and Neil Conway. > > > Bugs: MESOS-4787 > https://issues.apache.org/jira/browse/MESOS-4787 > > > Repository: mesos > > > Description > ------- > > Just as the ProcessManager needs the delegate name to know which > process to service root HTTP requests from, the Help process needs to > know the delegate name so it can generate the proper USAGE strings. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/help.hpp > 93306adfd64cc08933232e0db78d9efacb966018 > 3rdparty/libprocess/src/help.cpp bac980ddec98b34bdfd786b03d0691fefb93f45a > 3rdparty/libprocess/src/process.cpp > 01bc19bc6f4d78923bb3796b7dd0a9ab2b3108d1 > > Diff: https://reviews.apache.org/r/44690/diff/ > > > Testing > ------- > > I spun up a master and an agent and looked at their /help endpoint to verify > that the updated USAGE strings include information about accessing the > enpoint without the process name. > > > Thanks, > > Kevin Klues > >