----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review123319 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line 55) <https://reviews.apache.org/r/44762/#comment185536> Because both CgroupsIsolatorProcess and Subsystem need access CgroupsIsolatorInfo, I use struct here. src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line 75) <https://reviews.apache.org/r/44762/#comment185537> Could not use something like ``` vector<SubsystemInfo> ``` here. src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 63) <https://reviews.apache.org/r/44762/#comment185535> Because we set ContainerLimiation when oom or in some scenarios, I use WatchCallback here. src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 93) <https://reviews.apache.org/r/44762/#comment185538> Because besides `assign`, sometimes we would like to register oom listener in mem subsytem, I move it from `CgroupsIsolatorProcess` to `Subsystem` as a default implementation. But it would assign to same hierarchy multiple times, should I move it back to `CgroupsIsolatorProcess`? - haosdent huang On March 13, 2016, 5:50 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44762/ > ----------------------------------------------------------- > > (Updated March 13, 2016, 5:50 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4697 > https://issues.apache.org/jira/browse/MESOS-4697 > > > Repository: mesos > > > Description > ------- > > Add CgroupsIsolator. This is only used for discussion. > > > Diffs > ----- > > src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 > src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/info.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/info.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44762/diff/ > > > Testing > ------- > > The relations between classes in this proposal is: > > ``` > +------------------------+ > | | > | CgroupsIsolatorProcess <---------------------+ > | | | > +------------^-----------+ + > | Belongs to > + + > Belongs to | > + | > | | > +-----+-----+ +-----------+---------+ > | | | | > | Subsystem <---+Used by+---+ CgroupsIsolatorInfo | > | | | | > +-----------+ +---------------------+ > ``` > > > Thanks, > > haosdent huang > >
