----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review124340 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 363) <https://reviews.apache.org/r/44762/#comment186825> I think what you can do is to save a future in each Subsystem. I am not sure if we have a primitive in libprocess to watch for if any future is ready or not. We can potentially add that. This function just watch for all futures in Subsystems and return that if any of them is ready. If any of them failed/discarded, return the failure. - Jie Yu On March 13, 2016, 5:50 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44762/ > ----------------------------------------------------------- > > (Updated March 13, 2016, 5:50 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4697 > https://issues.apache.org/jira/browse/MESOS-4697 > > > Repository: mesos > > > Description > ------- > > Add CgroupsIsolator. This is only used for discussion. > > > Diffs > ----- > > src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 > src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/info.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/info.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44762/diff/ > > > Testing > ------- > > The relations between classes in this proposal is: > > ``` > +------------------------+ > | | > | CgroupsIsolatorProcess <---------------------+ > | | | > +------------^-----------+ + > | Belongs to > + + > Belongs to | > + | > | | > +-----+-----+ +-----------+---------+ > | | | | > | Subsystem <---+Used by+---+ CgroupsIsolatorInfo | > | | | | > +-----------+ +---------------------+ > ``` > > > Thanks, > > haosdent huang > >
