> On March 13, 2016, 6:47 p.m., Benjamin Bannier wrote: > > support/clang-format, line 2 > > <https://reviews.apache.org/r/44758/diff/1/?file=1296800#file1296800line2> > > > > It would be great if you could use this opportunity and explicitly > > expand the values of the `Google` style we do rely on. This avoids the > > problem of upstream changing their definition of `Google` style, and then > > users on our end using different styles, depending on their clang version. > > This was an issue in the past with clang-format from trunk. > > > > You should use `clang-format -dump-config` with some 3.5 and 3.8 > > versions and adjust values where needed. As a starting point, I am using > > this config with clang-format from trunk (but cannot vouch for its quality), > > > > https://gist.github.com/bbannier/6e47d32eec9e0093711a
Thanks for the feedback Benjamin. I updated the clang-format file based on the Google style value expansion in 3.8. Please let me know if there are any other issues. - Yong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123323 ----------------------------------------------------------- On March 14, 2016, 1:09 a.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44758/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 1:09 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4906 > https://issues.apache.org/jira/browse/MESOS-4906 > > > Repository: mesos > > > Description > ------- > > Upgrade to clang-format-3.8 (MESOS-4906). > > > Diffs > ----- > > docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 > support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e > > Diff: https://reviews.apache.org/r/44758/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yong Tang > >
