----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123734 -----------------------------------------------------------
Fix it, then Ship it! support/clang-format (lines 24 - 35) <https://reviews.apache.org/r/44758/#comment185992> These do nothing unless `BreakBeforeBraces` is set to `Custom`. Our style matches `Mozilla`, so let's remove these. support/clang-format (line 37) <https://reviews.apache.org/r/44758/#comment185976> `s/Linux/Mozilla/` support/clang-format (lines 50 - 56) <https://reviews.apache.org/r/44758/#comment186000> We can help out a little more here: The following code orders the headers: (1) C standard library headers (2) C++ standard library headers (3) Our public headers (4) Our private headers ``` IncludeCategories: - Regex: '^<.*.h>' Priority: 1 - Regex: '^<.*.hpp>' Priority: 3 - Regex: '^<.*>' Priority: 2 - Regex: '.*' Priority: 4 ``` __NOTE__: 3 seems to need to appear before 2, probably because it's more specific. - Michael Park On March 14, 2016, 1:09 a.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44758/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 1:09 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4906 > https://issues.apache.org/jira/browse/MESOS-4906 > > > Repository: mesos > > > Description > ------- > > Upgrade to clang-format-3.8 (MESOS-4906). > > > Diffs > ----- > > docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 > support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e > > Diff: https://reviews.apache.org/r/44758/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yong Tang > >
