> On March 6, 2016, 8:51 a.m., Klaus Ma wrote: > > support/install-nvidia-gdk.sh, lines 3-13 > > <https://reviews.apache.org/r/44360/diff/2/?file=1280297#file1280297line3> > > > > Are we going to provide documents about those vars? e.g. which version > > are we going to support? > > Kevin Klues wrote: > From talking to Nvidia, this is actually the last version of the GDK they > plan to release in this form. It's only purpose is to provide a stub library > so that you can build code without a full CUDA install. Moreover, this is > just a helper to make it a little easier to get the tools installed on your > system. In fact, if you already have CUDA installed, I would recommend > *against* using this script. I am adding a big comment at the top of the > script to mention all of this.
That's great :). I think it's better to also highlight this in document. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review122216 ----------------------------------------------------------- On March 14, 2016, 3:35 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44360/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 3:35 p.m.) > > > Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. > > > Bugs: MESOS-4860 > https://issues.apache.org/jira/browse/MESOS-4860 > > > Repository: mesos > > > Description > ------- > > This script can be used to install the Nvidia GPU Deployment Kit (GDK) > on a mesos development machine. The purpose of the GDK is to provide > stubs for compiling code against Nvidia's latest drivers. It includes > all the necessary header files (nvml.h) and library files > (libnvidia-ml.so) necessary to build mesos with Nvidia GPU support. > However, it does not actually contain any driver code, and it can't be > used to interact with any GPUs installed on a system. For that, you > will have to find the latest released drivers themselves. > > We provide this script only for convenience, so that developers > working on non-GPU equipped systems can build code with Nvidia GPU > support. It is a simple wrapper around the official GDK installer > script provided by Nvidia, which can be downloaded here: > > https://developer.nvidia.com/gpu-deployment-kit > > The script itself takes a few parameters. Run it as > 'support/install-nvidia-gdk.sh --help' to see its usage semantics. > > > Diffs > ----- > > support/install-nvidia-gdk.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/44360/diff/ > > > Testing > ------- > > I ran the script on my Mac to verify that it fails out cleanly. > > I ran it on a linux box to exercise each of the different flags that can be > passed to it. > ``` > install-nvidia-gdk.sh --install-dir=<root_directory> > install-nvidia-gdk.sh --install-dir=<non_root_directory> > install-nvidia-gdk.sh --install-dir=<root_directory> --update-ldcache > install-nvidia-gdk.sh --install-dir=<non_root_directory> --update-ldcache > ``` > > With each combination, I verified that the proper error messages were > reported, or that the installation was successful. > > As per one of the comments below, I also temporarily changed the download URL > for the installer to make sure that the `wget` call errored out cleanly. > > > Thanks, > > Kevin Klues > >
