-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44834/#review123604
-----------------------------------------------------------




include/mesos/mesos.proto (line 626)
<https://reviews.apache.org/r/44834/#comment185841>

    BTW, I removed this comment because I thought it was confusing: frameworks 
"create" volumes by sending `Offer::Operation::Create` with an appropriate 
resource value. As written, it suggests (to me) that you can create a 
persistent volume by just launching a task with the persistence info defined.


- Neil Conway


On March 15, 2016, 5:54 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44834/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 5:54 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2198
>     https://issues.apache.org/jira/browse/MESOS-2198
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is generally a bad idea for (at least) two reasons:
> 
> (1) Determining when the previous entity with the ID has terminated
>     can be non-trivial. Several frameworks have done this incorrectly
>     in the past.
> 
> (2) When reusing IDs, logs can be more difficult to read because the
>     same ID can refer to different entities at different times.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a 
>   include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 
> 
> Diff: https://reviews.apache.org/r/44834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to