----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44834/#review123626 -----------------------------------------------------------
include/mesos/mesos.proto (line 66) <https://reviews.apache.org/r/44834/#comment185856> Shall we list all termial state here and ditto for v1. TASK_FINISHED = 2; // TERMINAL: The task finished successfully. TASK_FAILED = 3; // TERMINAL: The task failed to finish successfully. TASK_KILLED = 4; // TERMINAL: The task was killed by the executor. TASK_LOST = 5; // TERMINAL: The task failed but can be rescheduled. TASK_ERROR = 7; // TERMINAL: The task description contains an error. - Guangya Liu On 三月 15, 2016, 5:54 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44834/ > ----------------------------------------------------------- > > (Updated 三月 15, 2016, 5:54 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-2198 > https://issues.apache.org/jira/browse/MESOS-2198 > > > Repository: mesos > > > Description > ------- > > This is generally a bad idea for (at least) two reasons: > > (1) Determining when the previous entity with the ID has terminated > can be non-trivial. Several frameworks have done this incorrectly > in the past. > > (2) When reusing IDs, logs can be more difficult to read because the > same ID can refer to different entities at different times. > > > Diffs > ----- > > include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a > include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 > > Diff: https://reviews.apache.org/r/44834/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
