----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review123642 -----------------------------------------------------------
src/master/flags.cpp (line 224) <https://reviews.apache.org/r/44846/#comment185867> s/credantials/credentials... src/master/flags.cpp (line 225) <https://reviews.apache.org/r/44846/#comment185868> s/ or / or (deprecated) src/master/flags.cpp (line 227) <https://reviews.apache.org/r/44846/#comment185869> Note that the plain text file format is deprecated. src/master/flags.cpp (line 239) <https://reviews.apache.org/r/44846/#comment185873> IMO we could even drop this example... src/slave/flags.cpp (line 431) <https://reviews.apache.org/r/44846/#comment185870> why not JSON formated credential? src/slave/flags.cpp (line 432) <https://reviews.apache.org/r/44846/#comment185871> or (deprecated) src/slave/flags.cpp (line 434) <https://reviews.apache.org/r/44846/#comment185872> see above. - Joerg Schad On March 15, 2016, 11:36 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44846/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 11:36 a.m.) > > > Review request for mesos, Adam B and Joerg Schad. > > > Bugs: MESOS-2281 > https://issues.apache.org/jira/browse/MESOS-2281 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6 > docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480 > src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4 > src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 > src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9 > > Diff: https://reviews.apache.org/r/44846/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
