----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review124528 -----------------------------------------------------------
I know we leave deprecated flags in and document them as deprecated, but I'm tempted to not even mention the deprecated format of a flag that will continue to exist. Is that crazy? CHANGELOG (line 1) <https://reviews.apache.org/r/44846/#comment187129> Please add (WIP) at the end of this line CHANGELOG (line 4) <https://reviews.apache.org/r/44846/#comment187130> s/providing// docs/configuration.md (lines 507 - 508) <https://reviews.apache.org/r/44846/#comment187131> Let's not mention the deprecated format anymore. If they're still using it, they know how to format it. If not, they should just start with the new json format docs/configuration.md (line 510) <https://reviews.apache.org/r/44846/#comment187132> s/JSON file Example/Example/ docs/configuration.md (lines 993 - 995) <https://reviews.apache.org/r/44846/#comment187133> Don't mention the deprecated format anymore. src/master/flags.cpp (lines 224 - 227) <https://reviews.apache.org/r/44846/#comment187134> Remove the references to the deprecated format src/master/flags.cpp (line 238) <https://reviews.apache.org/r/44846/#comment187135> No need for the final `\n` src/slave/flags.cpp (lines 430 - 434) <https://reviews.apache.org/r/44846/#comment187136> "Path to a JSON-formatted file containing the credential to use to authenticate with the master." - Adam B On March 15, 2016, 7:01 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44846/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 7:01 a.m.) > > > Review request for mesos, Adam B and Joerg Schad. > > > Bugs: MESOS-2281 > https://issues.apache.org/jira/browse/MESOS-2281 > > > Repository: mesos > > > Description > ------- > > Deprecated the plain text credential format. > > > Diffs > ----- > > CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6 > docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480 > docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b > docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 > src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4 > src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 > src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9 > > Diff: https://reviews.apache.org/r/44846/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
