----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/#review123741 -----------------------------------------------------------
Looks great, just some suggestions for clarifying the documentation. include/mesos/mesos.proto (lines 347 - 352) <https://reviews.apache.org/r/44656/#comment185987> I'm realizing I should have made this more clearly separate out the interpretation for command tasks. Could you rephrase this to say that this allows a configurable grace period between gently and forcibly killing the task? Then we can say that for executor-less command-based tasks, mesos will currently perfrom the graceful kill via a SIGTERM to the process and the forcible kill via a SIGKILL to the process. Does that seem clearer for the users? include/mesos/mesos.proto (lines 1240 - 1241) <https://reviews.apache.org/r/44656/#comment185985> I'm thinking we need to clarify that the health check / kill policy are provided for executor-less tasks (where mesos uses a built-in executor). And for tasks that specify an executor, it is the executor's responsibility to provide the health checking and kill policy. Does that seem clearer for the users? include/mesos/v1/mesos.proto (lines 359 - 360) <https://reviews.apache.org/r/44656/#comment185984> This is missing the NOTE from the non-v1 version? - Ben Mahler On March 15, 2016, 3:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44656/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 3:54 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4909 > https://issues.apache.org/jira/browse/MESOS-4909 > > > Repository: mesos > > > Description > ------- > > Describes a kill policy for a task. Currently does not express > different policies (e.g. hitting HTTP endpoints). For now, this > controls how long to wait between SIGTERM and SIGKILL. > > > Diffs > ----- > > include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b > include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b > > Diff: https://reviews.apache.org/r/44656/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
