> On March 19, 2016, 12:38 a.m., Ben Mahler wrote:
> > include/mesos/mesos.proto, lines 366-370
> > <https://reviews.apache.org/r/44656/diff/6/?file=1306237#file1306237line366>
> >
> >     How about following similar language from the executor info change?
> >     
> >     ```
> >       // The grace period specifies how long to wait before forcibly
> >       // killing the task. It is recommended to attempt to gracefully
> >       // kill the task (and send TASK_KILLING) to indicate that the
> >       // graceful kill is in progress. Once the grace period elapses,
> >       // if the task has not terminated, a forcible kill should occur.
> >       // The task should not assume that it will *always* be alloted
> >       // the full grace period. For example, the executor may be
> >       // shutdown more quickly by the agent, or failures / forcible
> >       // terminations may occur.
> >     ```
> >     
> >     However, you already have a NOTE above, so I'd rather not call it out 
> > again here.

I'd rather have this comment because the one for `KillPolicy` may change once 
we add more policies.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44656/#review124339
-----------------------------------------------------------


On March 18, 2016, 5:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44656/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4909
>     https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Describes a kill policy for a task. Currently does not express
> different policies (e.g. hitting HTTP endpoints). For now, this
> controls how long to wait between SIGTERM and SIGKILL.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
>   include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
> 
> Diff: https://reviews.apache.org/r/44656/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to