> On March 15, 2016, 8:02 p.m., Neil Conway wrote: > > Is it feasible/portable to have a test case for this change? > > Cong Wang wrote: > Yes, like in our case, you can create some socket or device file and try > to remove the directory contains it, it would fail without this patch.
AFAICT tests have already been added: https://github.com/apache/mesos/commit/c55ca2941b0119c13764bccdebcea46119e69e4e - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44230/#review123733 ----------------------------------------------------------- On March 1, 2016, 10:01 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44230/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 10:01 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > We currently dont handle special files like device files in rmdir. This change > adds FS_DEFAULT as one of the cases where we try to unlink a file. > > Reference: http://man7.org/linux/man-pages/man3/fts.3.html > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > bc420c9c10d93ddd619a9eb2c5f4db67f31d722f > > Diff: https://reviews.apache.org/r/44230/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
