Yes thats correct. I am planning to submit a patch that will add the test. Will also address the symlink case.
-jojy > On Mar 15, 2016, at 3:33 PM, Cong Wang <[email protected]> wrote: > > This is an automatically generated e-mail. To reply, > visit:https://reviews.apache.org/r/44230/ > <https://reviews.apache.org/r/44230/> > On March 15th, 2016, 8:02 p.m. UTC, Neil Conway wrote: > > Is it feasible/portable to have a test case for this change? > On March 15th, 2016, 8:58 p.m. UTC, Cong Wang wrote: > > Yes, like in our case, you can create some socket or device file and try to > remove the directory contains it, it would fail without this patch. > On March 15th, 2016, 9:26 p.m. UTC, David Robinson wrote: > > AFAICT tests have already been added: > https://github.com/apache/mesos/commit/c55ca2941b0119c13764bccdebcea46119e69e4e > None of these tests covers this bug. > > - Cong > > > On March 1st, 2016, 10:01 p.m. UTC, Jojy Varghese wrote: > > Review request for mesos and Jie Yu. > By Jojy Varghese. > Updated March 1, 2016, 10:01 p.m. > > Repository: mesos > Description > > We currently dont handle special files like device files in rmdir. This change > adds FS_DEFAULT as one of the cases where we try to unlink a file. > > Reference: http://man7.org/linux/man-pages/man3/fts.3.html > Testing > > make check. > Diffs > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > (bc420c9c10d93ddd619a9eb2c5f4db67f31d722f) > View Diff <https://reviews.apache.org/r/44230/diff/>
