----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123828 -----------------------------------------------------------
Patch looks great! Reviews applied: [43613, 43614, 43629, 43630, 43615] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 16, 2016, 12:21 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43615/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 12:21 a.m.) > > > Review request for mesos, Bernd Mathiske and Artem Harutyunyan. > > > Bugs: MESOS-4633 and MESOS-4634 > https://issues.apache.org/jira/browse/MESOS-4633 > https://issues.apache.org/jira/browse/MESOS-4634 > > > Repository: mesos > > > Description > ------- > > Includes the following changes: > > * Added the `<process/owned.hpp>` header where appropriate. > * Added the namespace `using process::Owned;` where appropriate. > * Generally replaced `Try<PID<Master>>` with `Try<Owned<cluster::Master>>`. > And `Try<PID<Slave>>` with `Try<Owned<cluster::Slave>>`. > * Added the (now required) `MasterDetector` argument to all slaves. Before, > this was fetched from the first master in `Cluster`. > * Removed `Shutdown();` from all tests. > * Replaced `Stop(...)` with the appropriate master/slave destruction calls. > * Wrap various slave objects in `Owned` (i.e. containerizers, isolators, > launchers, etc). > * Replace `CHECK` in tests with `ASSERT`. > > > Diffs > ----- > > src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 > src/tests/command_executor_tests.cpp > 0d2fcf6d4b8d9a925eb6748e6bd33cf279b8f7f8 > src/tests/container_logger_tests.cpp > 00f4129e46aa9268fbb66da25b34e61004fa87b2 > src/tests/containerizer/docker_containerizer_tests.cpp > 8afaa4dab3984e9866b7b223e8e2e70ef83a39dc > src/tests/containerizer/external_containerizer_test.cpp > 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 > src/tests/containerizer/filesystem_isolator_tests.cpp > e72239a55724f1aeeec5362cc370c93dbeca7164 > src/tests/containerizer/isolator_tests.cpp > 342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 > src/tests/containerizer/memory_pressure_tests.cpp > 03879d99c371f296f8d9904666911b34209c114d > src/tests/containerizer/mesos_containerizer_tests.cpp > 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 > src/tests/containerizer/port_mapping_tests.cpp > a1427fd0157dee343b643f3272dba8ffea61f7b0 > src/tests/containerizer/provisioner_docker_tests.cpp > b2663a83afccbb156f10b4703f29ee0f638384bf > src/tests/containerizer/runtime_isolator_tests.cpp > 1625614f560a4c9a644b1b9e9568199f30373ab5 > src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 > src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 > src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b > src/tests/executor_http_api_tests.cpp > 2fc0893f5f5e80a783296fb31b30abe86d92df1b > src/tests/fault_tolerance_tests.cpp > 67f362747ac4301a74693aeaa5631b7dd866e782 > src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf > src/tests/health_check_tests.cpp 9605859b665645654bbdb2688455cae2d692a057 > src/tests/hook_tests.cpp bb287c77493209e663a37e7f88d09a0459855f7d > src/tests/http_fault_tolerance_tests.cpp > 7c7f3d90210148176e83553346100a506f263591 > src/tests/master_allocator_tests.cpp > cba7c36471f93b678d94e1da0251a28a893696b1 > src/tests/master_authorization_tests.cpp > 6a4de4709960d7ca505e99396e14a1bb51d6902d > src/tests/master_contender_detector_tests.cpp > 255ab8119a04b55bb4f1b61dee19c4be64499376 > src/tests/master_quota_tests.cpp f1277f03f5b5cf735fea7ba324a27614a829cd50 > src/tests/master_slave_reconciliation_tests.cpp > d41178eb41df519073fc0890c5716bbc9fed6ad2 > src/tests/master_tests.cpp e8c39e775d6ca218ce74cfc6bb50c7576d73e90e > src/tests/master_validation_tests.cpp > c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 > src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd > src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 > src/tests/oversubscription_tests.cpp > e528476cd83b0e3f7ae8cea7d86dfabc1f66484e > src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 > src/tests/persistent_volume_endpoints_tests.cpp > b5f425ab7f2b4a540418d761bea145565467bd2b > src/tests/persistent_volume_tests.cpp > e9215de2e073025f67cdc73e8a8de38cf030671f > src/tests/rate_limiting_tests.cpp 352a5e7a58b500c25c7c8a421047c4e79434e38e > src/tests/reconciliation_tests.cpp e8f3f29836652d20a6ee1bb5231a15e71eb76990 > src/tests/registrar_zookeeper_tests.cpp > 3df9779ee5d076e16f6a538326693a36f986b6d0 > src/tests/repair_tests.cpp 0dfb557a62f64baf2334dbc9f75ecdfb10473c2d > src/tests/reservation_endpoints_tests.cpp > f95ae7a32c3809d150adf1e9e515a3b527e61699 > src/tests/reservation_tests.cpp c88091635949037fcfc6be504043764f9af35f79 > src/tests/role_tests.cpp f45ee816f6ab2f988fbe4efdb14c58b7538e06c8 > src/tests/scheduler_driver_tests.cpp > f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 > src/tests/scheduler_event_call_tests.cpp > 8c02ceeb3ec1783cb2f63f100700508e70f586e4 > src/tests/scheduler_http_api_tests.cpp > dfb0f51fec67a3951e396eab28eedb0dbf9493ae > src/tests/slave_tests.cpp 87c5e8caa63095fb8325ae019041398d49aa1edf > src/tests/status_update_manager_tests.cpp > 9440d3b14a7f5fe6277bd1d61a891014f5de9fc3 > src/tests/teardown_tests.cpp 2b8e6875022910a729732cee5e03f03099fe08e7 > > Diff: https://reviews.apache.org/r/43615/diff/ > > > Testing > ------- > > sudo make check > ``` > | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 12 | Ubuntu 14 | > Ubuntu 15 | > Non-SSL | :) | !@# | #% | # | :) | :) | > :) | > With-SSL | :) | @ $ | #% | :) | :) | :) | > :) | > > :) = Passed. > ! = LinuxFilesystemIsolatorTest.ROOT_RecoverOrphanedPersistentVolume > @ = ProvisionerDockerRegistryPullerTest.ROOT_INTERNET_CURL_ShellCommand > # = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery > $ = LinuxFilesystemIsolatorTest.ROOT_MultipleContainers > % = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes > ``` > > > Thanks, > > Joseph Wu > >
