> On March 18, 2016, 2:05 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/collect.hpp, line 260 > > <https://reviews.apache.org/r/44547/diff/8/?file=1304700#file1304700line260> > > > > Missed a couple extranous spaces here (i.e. `>* >*`). > > Anurag Singh wrote: > Thanks. I'm curious ... do you use a tool for checking the styling? Or > have you written your own scripts?
I personally don't. (Which means I do this by eye.) We're eventually going to run `clang-tidy` on the whole code base (and possibly as a pre-commit hook), so these style nits should largely go away in future. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/#review124281 ----------------------------------------------------------- On March 17, 2016, 5:29 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44547/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 5:29 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > Added functions in promises to the collect header. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/collect.hpp > 5a92b72eb7668494dc832ec446a41b3d673a20cc > > Diff: https://reviews.apache.org/r/44547/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
