> On 三月 18, 2016, 7:03 p.m., haosdent huang wrote:
> > docs/versioning.md, line 85
> > <https://reviews.apache.org/r/45033/diff/1/?file=1305277#file1305277line85>
> >
> >     Any reason we need change here?
> 
> Yong Tang wrote:
>     Hi haosdent, the left is one unicode (U+2026) of "Horizontal Ellipsis" 
> (three dots). Inside the md file you will see it is 0xE2,0x80,0xA6 (UTF-8) if 
> you use binary mode in vi.  The right are three ascii characters of dot 
> (0xA0).
> 
> Yong Tang wrote:
>     By the way, thanks for the review and the help. I will address the rest 
> of the issues later.

Thank you for explaination. Got it.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review124253
-----------------------------------------------------------


On 三月 18, 2016, 11:11 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> -----------------------------------------------------------
> 
> (Updated 三月 18, 2016, 11:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and haosdent 
> huang.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This review request tries to add a commit hook for checking non-ascii
> characters. It scans .cpp, .hpp, .cc, .h, and .md files and report
> error if non-ascii characters exists.
> 
> As part of this review request, two non-ascii characters are identified
> in versioning.md (one in Ln 85 and another in Ln 96) and are corrected
> accordingly.
> 
> 
> Diffs
> -----
> 
>   docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
>   support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 
>   support/non-ascii.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45033/diff/
> 
> 
> Testing
> -------
> 
> Tested manually and found two non ascii characters in docs/versioning.md 
> (fixed as part of this review request).
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to