> On March 18, 2016, 7:03 p.m., haosdent huang wrote:
> > support/non-ascii.py, line 21
> > <https://reviews.apache.org/r/45033/diff/1/?file=1305279#file1305279line21>
> >
> >     Seems we have to update this when we update third part dependencies 
> > every time? For example, if we update protobuf to 2.6, this rule need 
> > update as well. Is it possible to avoid this?

Hi haosdent, I take a look at this issue. The exclude_file pattern was from 
mesos-style.py. Not knowing enough about the source tree history of mesos 
though it turns out that 3rd party files are actually placed inside the build 
directory and is filtered out anyway. So those version specific patterns are 
not needed any more. I just removed those unneeded patterns.


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review124253
-----------------------------------------------------------


On March 19, 2016, 6:26 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> -----------------------------------------------------------
> 
> (Updated March 19, 2016, 6:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and haosdent 
> huang.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This review request tries to add a commit hook for checking non-ascii
> characters. It scans .cpp, .hpp, .cc, .h, and .md files and report
> error if non-ascii characters exists.
> 
> As part of this review request, two non-ascii characters are identified
> in versioning.md (one in Ln 85 and another in Ln 96) and are corrected
> accordingly.
> 
> 
> Diffs
> -----
> 
>   docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
>   support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 
>   support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 
>   support/non-ascii.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45033/diff/
> 
> 
> Testing
> -------
> 
> Tested manually and found two non ascii characters in docs/versioning.md 
> (fixed as part of this review request).
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to