> On March 17, 2016, 10:38 p.m., Joerg Schad wrote: > > src/authentication/http/basic_authenticator_factory.cpp, line 67 > > <https://reviews.apache.org/r/44678/diff/6/?file=1302910#file1302910line67> > > > > We do nor add additional information to the error is that a concious > > choice? If so please drop.
Added additional error info. > On March 17, 2016, 10:38 p.m., Joerg Schad wrote: > > src/tests/http_authentication_tests.cpp, line 103 > > <https://reviews.apache.org/r/44678/diff/6/?file=1302913#file1302913line103> > > > > Does it maybe make sense to create a helper function for this? Good idea! Done. > On March 17, 2016, 10:38 p.m., Joerg Schad wrote: > > src/examples/test_http_authenticator_module.cpp, line 43 > > <https://reviews.apache.org/r/44678/diff/6/?file=1302911#file1302911line43> > > > > Stupid question: Why makes this basic? It's "basic" because we're creating an instance of the `BasicAuthenticator`, which implements "HTTP basic authentication". - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review124111 ----------------------------------------------------------- On March 18, 2016, 12:20 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44678/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 12:20 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4850 > https://issues.apache.org/jira/browse/MESOS-4850 > > > Repository: mesos > > > Description > ------- > > Modified basic HTTP authenticator creator to accept realm. > > To accommodate different authentication realms for the master and agent, the > default basic HTTP authenticator needs to accept its authentication realm as > a parameter. This patch adds this parameter and modifies the HTTP > authentication tests to validate it appropriately. A new test was also added: > `HttpAuthenticationTest.BasicWithoutRealm`. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 > src/authentication/http/basic_authenticator_factory.cpp > 62f851685db3b42c52bbcb7cff3e4f4703004ed7 > src/examples/test_http_authenticator_module.cpp > 459b7046bd76d3043d2484a2dd30c10d7deaedd4 > src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f > src/tests/http_authentication_tests.cpp > cf2bb762272fa38e04e5c26aef2858300bbd0459 > > Diff: https://reviews.apache.org/r/44678/diff/ > > > Testing > ------- > > HTTP authentication tests were updated to pass the authentication realm to > the basic HTTP authenticator, and to adhere to the new credentials format in > the module parameters. A new test was also added: > `HttpAuthenticationTest.BasicWithoutRealm` > > `make check` was used to test on both OSX and CentOS 7. > > > Thanks, > > Greg Mann > >