-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45014/#review124735
-----------------------------------------------------------



Instead of handling /containers endpoint in Slave, I would suggest we dispatch 
the request to ResourceMonitor. I will rename ResourceMonitor to 
ContainerMonitor, and we will be deprecating the /monitor/statistics endpoints 
in the future.


src/slave/slave.cpp (lines 5001 - 5005)
<https://reviews.apache.org/r/45014/#comment187385>

    Can we call monitor.containers() here instead? That means we need to expose 
'containers' in ContainerMonitor (ResourceMonitor).


- Jie Yu


On March 18, 2016, 5:27 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45014/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 5:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add /containers endpoint to return ResourceUsage.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 
> 
> Diff: https://reviews.apache.org/r/45014/diff/
> 
> 
> Testing
> -------
> 
> make check
> `curl agent_ip:port/containers` returns same json content as `curl 
> agent_ip:port/monitor/statistics.json`
> 
> This is a draft patch of adding /containers endpoint to agent 
> [MESOS-4891](https://issues.apache.org/jira/browse/MESOS-4891)
> 
> ContainerStatus will be added to response based on this patch.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Reply via email to