-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/
-----------------------------------------------------------
(Updated March 23, 2016, 11:39 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till
Toenshoff.
Changes
-------
Fixed comments in tests.
Bugs: MESOS-4850
https://issues.apache.org/jira/browse/MESOS-4850
Repository: mesos
Description
-------
Added authentication to agent HTTP endpoints.
This patch adds HTTP authentication to the `/state`, `/state.json`, and
`/flags` endpoints. Tests are also updated to use authentication when hitting
these endpoints, and a new test was added to probe these endpoints' behavior
when bad credentials are supplied: `SlaveTest.HTTPEndpointsBadAuthentication`.
Diffs (updated)
-----
src/slave/http.cpp 0117827d73bd1b4c96ef261d4573abf70f52c6b3
src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/containerizer/docker_containerizer_tests.cpp
f6fce7df82417e029fadf805d6e0b793f396aa69
src/tests/containerizer/isolator_tests.cpp
6a2e25b967742c034364d19372f06aa9f9cdf828
src/tests/fault_tolerance_tests.cpp f99413f56e96a796d3d45decad1f049e6a238789
src/tests/health_check_tests.cpp d32164aeb1eb439bd062afa28614dd919e24f06b
src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169
Diff: https://reviews.apache.org/r/44553/diff/
Testing
-------
Tests were updated to use authentication when hitting the affected agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
