----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review125167 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line 268) <https://reviews.apache.org/r/45002/#comment187956> `os::touch` would be a bit more readable, I think. - Neil Conway On March 24, 2016, 1:07 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45002/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 1:07 a.m.) > > > Review request for mesos, Jie Yu and Neil Conway. > > > Repository: mesos > > > Description > ------- > > According to the documentation for fts_open, either FTS_PHYSICAL or > FTS_LOGICAL > SHOULD be provided. We need FTS_PHYSICAL for the case of rmdir as we dont want > to resolve the symlink targets while deleting them. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > cbc97596cd8ed1e6d4261568fd0086c86e063232 > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp > 5bd154e40c6eeeeb45e74967b620141cc373bdee > src/tests/containerizer/provisioner_appc_tests.cpp > 23a5b1059b4d9fde1e4a1aab5cd4fa6d05862332 > > Diff: https://reviews.apache.org/r/45002/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
