-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review125393
-----------------------------------------------------------


Fix it, then Ship it!




Looks great. I'll fix up these last bits and commit it.


CHANGELOG (lines 5 - 9)
<https://reviews.apache.org/r/44846/#comment188179>

    We like to put these in numerical order.



docs/configuration.md (lines 990 - 991)
<https://reviews.apache.org/r/44846/#comment188180>

    The strings in configuration.md should match the strings in flags.cpp. 
Looks like this one didn't get updated with the most recent rewording.


- Adam B


On March 24, 2016, 6:22 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
> 
> (Updated March 24, 2016, 6:22 a.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-2281
>     https://issues.apache.org/jira/browse/MESOS-2281
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Deprecated the plain text credential format.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 1fadaa1819c9b1a801752b1c0ddd572b82e6c170 
>   docs/authentication.md 9f64f657d1a01f85f0132cb7264e2b85d0d3dc59 
>   docs/configuration.md 70686adeca239b5962652a17661c8b0d44ca6708 
>   docs/upgrades.md 85d02929b58b465f22d0e9991f6cf66f52b6d9a6 
>   src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4 
>   src/master/flags.cpp 9b65dee02e3505f22aaa967899903f80fe0e7c57 
>   src/slave/flags.cpp 71685cee58322e608139f7c344c2e954f7e14322 
> 
> Diff: https://reviews.apache.org/r/44846/diff/
> 
> 
> Testing
> -------
> 
> make check
> Created the documentation using the Dockerfile in `support/site-docker` to 
> make sure that the markdown files renders correctly.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to