----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/#review125499 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp (line 243) <https://reviews.apache.org/r/45122/#comment188296> Can we create a new test, instead of piggyback on this test? In the new test, you can test the 'creation' of persistent volume as well for PATH type disk. src/tests/persistent_volume_tests.cpp (line 387) <https://reviews.apache.org/r/45122/#comment188298> Do you want to check if MOUNT disk is empty? src/tests/persistent_volume_tests.cpp (line 809) <https://reviews.apache.org/r/45122/#comment188297> What the purpose of adding another file here? src/tests/persistent_volume_tests.cpp (line 848) <https://reviews.apache.org/r/45122/#comment188299> Ditto. Check if MOUTN disk is empty. - Jie Yu On March 21, 2016, 6:44 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45122/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 6:44 p.m.) > > > Review request for mesos, Jie Yu and Joris Van Remoortere. > > > Bugs: MESOS-2408 > https://issues.apache.org/jira/browse/MESOS-2408 > > > Repository: mesos > > > Description > ------- > > Updated tests for deletion of persistent volumes. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 26fff19daa8b175fdcc06fd9467224d5920a1967 > > Diff: https://reviews.apache.org/r/45122/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
