> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > <https://reviews.apache.org/r/45122/diff/1/?file=1308848#file1308848line810> > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if files are directly written into the directory > that corresponds to the persistent volume (not via the task itself), they are > still cleaned up when the volume is destroyed. > > Jie Yu wrote: > hum, I still don't understand. What's the purpose of this test? to > simulate what situation? > > Neil Conway wrote: > The situation I wanted to test is that you have a directory `/foo` that > is being used by a Mesos task as a persistent volume. Another process on the > box writes a file `/foo/bar`, and then the Mesos task terminates and the > volume is destroyed. The test checks that `/foo/bar` is removed, even though > it wasn't created by the Mesos task. > > Jie Yu wrote: > I understand what it is doing. I don't understand is: is this a > legitimate use case? You mean some out of band process is writing the > persistent volume? This does not fit well with the Mesos model, isn't it? I > would suggest we don't add those. > > Neil Conway wrote: > Well, we're already testing whether an out-of-band process can read from > the persistent volume (for `filePath1`), so it seemed natural to test writing > to it as well -- happy to remove it if you'd prefer though. > > Jie Yu wrote: > I think the 'read' is to make sure the file written by the task is > actually persisted in the persistent volume.
Okay, removed. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/#review125499 ----------------------------------------------------------- On March 28, 2016, 6:20 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45122/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 6:20 p.m.) > > > Review request for mesos, Jie Yu and Joris Van Remoortere. > > > Bugs: MESOS-2408 > https://issues.apache.org/jira/browse/MESOS-2408 > > > Repository: mesos > > > Description > ------- > > Updated tests for deletion of persistent volumes. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 26fff19daa8b175fdcc06fd9467224d5920a1967 > > Diff: https://reviews.apache.org/r/45122/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
