> On March 26, 2016, 5:04 a.m., Vinod Kone wrote: > > Can you split this review into 2 reviews > > > > 1) Changes needed just for protobuf upgrade to 2.6.1 > > 2) Changes needed to make it compile for PPC
Thanks, actually there is no specific changes for PPC, I just separated this patch for three: mesos, libprocess and stout. - Zhiwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/#review125471 ----------------------------------------------------------- On March 24, 2016, 9:28 a.m., Zhiwei Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44257/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 9:28 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4678 > https://issues.apache.org/jira/browse/MESOS-4678 > > > Repository: mesos > > > Description > ------- > > Upgrade protobuf to 2.6.1 to support PowerPC LE platform. > > > Diffs > ----- > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > 3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz > e600ac57be4c88efb5f146e4b3ec226d8f685033 > 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/README.md > c534835db7baca1138791f2c700e95ff73052d85 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h > 3d1f13082a65f9b1694ee7c65ba0cec131c18c5a > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc > fb11b1147b3a1872f60e90d0691723f9b2985427 > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1fbbbb2d19ffb8 > src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af > src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 > src/python/native_common/ext_modules.py.in > c335bd83024bc07b6243dd59d775e7f29adc7520 > src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b > > Diff: https://reviews.apache.org/r/44257/diff/ > > > Testing > ------- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
