-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45230/
-----------------------------------------------------------

(Updated March 28, 2016, 11:41 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

Addressed comments.


Repository: mesos


Description (updated)
-------

Executing arbitrary setup functions while creating new processes is
dangerous as all functions called have to be async safe. As setup
functions are used for only very few purposes (setsid, chdir, monitoring
and killing a process (see upcoming review) it makes sense to support
them safely via parameters to subprocess. Note this review by itself
-without the following ones- removing the uses of the old interface will
break the build.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
2ca705524c8f9bba3c03eef296dc04a353dd236c 
  3rdparty/libprocess/include/process/subprocess.hpp 
e0c306aa5cf5f393abb73768bbd287c45730f076 
  3rdparty/libprocess/src/subprocess.cpp 
b99bad04f7251169df3bfcec5dee459977440997 

Diff: https://reviews.apache.org/r/45230/diff/


Testing
-------

tested entire chain (see https://reviews.apache.org/r/45236/).


Thanks,

Joerg Schad

Reply via email to