----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45231/ -----------------------------------------------------------
(Updated March 28, 2016, 11:43 a.m.) Review request for mesos and Joris Van Remoortere. Changes ------- Addressed comments. Summary (updated) ----------------- Removed the use of subprocess setup functions [2/7]. Repository: mesos Description (updated) ------- This review follows the previous one and removes most (see following reviews) usages setup functions throughout the code. Diffs (updated) ----- src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53 src/health-check/main.cpp 36955dd5f77a056213762d92c39be4ca7dd5780c src/slave/container_loggers/lib_logrotate.cpp cf5f238eb3b6217b848cf23f8c9cd1848bf9a9f0 src/slave/containerizer/docker.cpp 0133628f5b37dc0d3aa12f210c61dfc07deac18b src/slave/containerizer/external_containerizer.cpp fe368dd52644b89e47ffd4d947de290b3998fb1a src/slave/containerizer/fetcher.cpp 2b1e022c8dcd9734663f20fe963a8de0d6233715 src/slave/containerizer/mesos/containerizer.cpp e7f7e7fd1304e14dbfaab8b53cea16efc0417911 src/slave/containerizer/mesos/isolators/posix/disk.cpp b38d83fbb29f46552ffbda7b17cbc85af15550e1 src/slave/containerizer/mesos/launcher.hpp 8afac20c5a4093162f764412dbf16c4230dcb141 src/slave/containerizer/mesos/launcher.cpp ba012b1d577a770948a1bfcad5ad2d4977f81b2f src/slave/containerizer/mesos/linux_launcher.hpp 1763d8d48614e0a1e187505d90920e97c8e476fb src/slave/containerizer/mesos/linux_launcher.cpp 550c58263df257989568debe2858ef599e5f96e8 src/tests/containerizer/isolator_tests.cpp df506fc793e480e825b476e43c683ef8bcf676b2 src/tests/containerizer/launch_tests.cpp e0f934cf93f51316b35f34d34f3d0c5f004565d9 src/tests/containerizer/launcher.hpp 36405a97893f352147af4794fb39b6e621d95b58 src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079 src/tests/containerizer/ns_tests.cpp 4bf45e970bede713fa4ffce205627b149232fe2b src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a Diff: https://reviews.apache.org/r/45231/diff/ Testing ------- tested complete chain (see https://reviews.apache.org/r/45236/). Thanks, Joerg Schad
