----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44964/#review125813 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On March 29, 2016, 12:25 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44964/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 12:25 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This mostly targets unnecessary inclusion of stout headers, > which can be quite expensive to compile. > > > Diffs > ----- > > src/credentials/credentials.hpp 32492f2fa4126d26afe3ab0b523891023deb6a67 > src/examples/persistent_volume_framework.cpp > 3848e247994b511fb2b1dcde337f8f37bb7472da > src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 > src/slave/state.cpp 94b6959cbca7ba14dfc70caa3402fe7d72d4757a > src/tests/fetcher_tests.cpp bd86c962b37e2c584e261ba95798ac74a07091c2 > src/tests/group_tests.cpp ed10f1fe8a5cd2a353175e13ec3c464da69956f4 > src/tests/master_contender_detector_tests.cpp > bbce379e5a0a0ca608579d0ab2b10970e9cd5ef1 > src/tests/master_quota_tests.cpp c2b46d23002481e63ff162e8628f9b974e3e8ef9 > src/tests/mesos.hpp f2a29d0ddce5ef2b9ef2f0155c428311a67dbab3 > src/tests/module_tests.cpp eddb0e5484964595797758e2742b10431e76c039 > src/tests/paths_tests.cpp 7952ae239470580f06df373c80f9115634b42640 > src/tests/persistent_volume_tests.cpp > aa097c3da1237e564dd4081c23034ab185be09bd > src/tests/script.cpp 36ddf40fc003435f852ca138f66c4f33def1637b > src/tests/state_tests.cpp 8fb2798e12fe77d6b93268e71e3a8261cb0842d5 > src/tests/status_update_manager_tests.cpp > 801767ba6b4a08a4f653a7735bf3a581a0f8f95f > src/tests/zookeeper_test_server.hpp > e2d8218fd7000904acaee2221da648c665da8dfc > src/zookeeper/group.cpp 7aa95a7b7eafe0a2c49dc077b3a4abd688e5d8e8 > > Diff: https://reviews.apache.org/r/44964/diff/ > > > Testing > ------- > > `make check` > > Timed the compilation of a few files to verify the compilation time > improvement -- e.g., removing an unused include of `stout/os.hpp` reduces > compile time by ~1 second on my laptop. > > > Thanks, > > Neil Conway > >
