> On March 28, 2016, 11:02 p.m., Jie Yu wrote:
> > Chatted with BenM on this. I think we should just kill the ResourceMonitor 
> > and move all the logics to the agent. We still need to keep the 
> > /monitor/statistics.json and /monitor/statistics endpoints for backwards 
> > compatibility. But since slave properly sets up the delagates, this should 
> > just work.

OK. Although I'm thinking to still keep monitor as a separate cpp file, instead 
of bloating slave.cpp further, which is already 6000+ LoC.


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45381/#review125770
-----------------------------------------------------------


On March 28, 2016, 11:54 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45381/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 11:54 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is used by ResourceMonitorProcess to collect ContainerStatus
> internally, to avoid dispatching this action back and forth between
> slave process and monitor process.
> 
> 
> Diffs
> -----
> 
>   src/slave/monitor.hpp 70a7c88fefd4577f53f85e3eccdd6b69ab6f3acd 
>   src/slave/monitor.cpp 5c1dd354595e67e5eb8888603c5d49850f84b84b 
>   src/slave/slave.hpp 3ba335fcd31a92af9609023daae328b7f4bf5e59 
>   src/slave/slave.cpp f383605a52f31d7b805ad6153adc409dcb40f83a 
>   src/tests/containerizer.hpp efc1ca87c00b04d70efd1e3f6acf4e763132d6b0 
>   src/tests/containerizer.cpp 4c7f5a26d38222daf013bd3ca9a133e12d7bf338 
>   src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
> 
> Diff: https://reviews.apache.org/r/45381/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> https://issues.apache.org/jira/browse/MESOS-4891
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Reply via email to