----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review126353 -----------------------------------------------------------
Can we rename test_contender_module.cpp to test_master_contender_module.cpp and so on? src/master/contenders/zookeeper.cpp (line 27) <https://reviews.apache.org/r/44289/#comment189342> This should come near the top. - Kapil Arya On March 23, 2016, 7:06 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44289/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 7:06 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > Added support for contender and detector modules. > > > Diffs > ----- > > include/mesos/module/contender.hpp PRE-CREATION > include/mesos/module/detector.hpp PRE-CREATION > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/examples/test_contender_module.cpp PRE-CREATION > src/examples/test_detector_module.cpp PRE-CREATION > src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 > src/master/contenders/zookeeper.cpp > 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 > src/master/detectors/zookeeper.cpp PRE-CREATION > src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 > src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 > src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a > > Diff: https://reviews.apache.org/r/44289/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
