> On March 31, 2016, 5:25 p.m., Kapil Arya wrote: > > include/mesos/master/contender.hpp, line 65 > > <https://reviews.apache.org/r/44287/diff/12/?file=1308472#file1308472line65> > > > > I am wondering if `type` can be replaced with `moduleName` or something > > more explicit.
as discussed, we'll be dropping this method so I'll skip this comment. - Anurag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review125914 ----------------------------------------------------------- On March 23, 2016, 11:04 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44287/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 11:04 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > MasterContender and MasterDetector abstract classes can be subclassed by > user-provided classes to allow for arbitrary contender/detector > implementations. > > > Diffs > ----- > > include/mesos/master/contender.hpp PRE-CREATION > include/mesos/master/detector.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44287/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
