> On April 1, 2016, 2:31 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 786 > > <https://reviews.apache.org/r/45546/diff/1/?file=1320825#file1320825line786> > > > > Shouldn't we return a failure?
I think we should not return a failure because there can be some containers do not want to opt in CNI networks. > On April 1, 2016, 2:31 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 790 > > <https://reviews.apache.org/r/45546/diff/1/?file=1320825#file1320825line790> > > > > Maybe s/netInfo/_networkInfo Agree, and let me fix it in `prepare` method as well. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126388 ----------------------------------------------------------- On March 31, 2016, 10:55 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45546/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 10:55 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented status() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 1c8e231813c0579b79681c5d18b1f799a727ead7 > > Diff: https://reviews.apache.org/r/45546/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
