----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126659 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (lines 93 - 95) <https://reviews.apache.org/r/45546/#comment189671> This is very confusing. We have both 'network' and 'networkInfo' in 'NetworkInfo'! How about this: we introduce an optional 'ContainerInfo' in 'Info': ``` struct Info { Option<ContainerInfo> containerInfo; } ``` - Jie Yu On April 1, 2016, 2:17 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45546/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 2:17 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4764 > https://issues.apache.org/jira/browse/MESOS-4764 > > > Repository: mesos > > > Description > ------- > > Implemented status() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 3a07540909ed771d1bd3b22888e04d5fb451710d > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 486c382365d5293cd9d53b8b239f70a543c46792 > > Diff: https://reviews.apache.org/r/45546/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
