> On March 30, 2016, 4:58 a.m., Adam B wrote: > > src/tests/master_allocator_tests.cpp, line 1519 > > <https://reviews.apache.org/r/45202/diff/2/?file=1314587#file1314587line1519> > > > > Don't you at least know that one of these parameters is the master's > > pid? > > Yongqiao Wang wrote: > Do you mean the parameters of addSlave function in allocator interface? > if yes, then master's pid is not one of them. Cloud you help to make this > comment clearly? Thanks.
Nevermind. Dropping. I just meant that all those `_`s you're filling in as parameters act as wildcards, and if there's something we definitely know (e.g. master pid), it'd be better to explicitly match against that instead of the wildcard. But I realize now that this is not an EXPECT_PROTOBUF or EXPECT_MESSAGE where one of the parameters is the 'from' pid, but rather this is an EXPECT_CALL, and everybody seems to pass it all `_`s. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review126083 ----------------------------------------------------------- On March 31, 2016, 12:15 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45202/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 12:15 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4881 > https://issues.apache.org/jira/browse/MESOS-4881 > > > Repository: mesos > > > Description > ------- > > Add test for rescinding offer trriggered by updating weights. > > > Diffs > ----- > > src/tests/dynamic_weights_tests.cpp > 6357cf42ec59c1388e95d6d808978918d5cd4a78 > src/tests/master_allocator_tests.cpp > b41ba2bda4d680f6fc42f525719973d56c11fe31 > src/tests/mesos.hpp a35371d7c1fcb9dbbe8a18c80522deb6bf789ad8 > > Diff: https://reviews.apache.org/r/45202/diff/ > > > Testing > ------- > > make && make check. > > $ ./src/mesos-tests > --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from MasterAllocatorTest/0, where TypeParam = > mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, > mesos::internal::master::allocator::DRFSorter> > > [ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights > [ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms) > [----------] 1 test from MasterAllocatorTest/0 (1059 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1070 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Yongqiao Wang > >
