> On April 5, 2016, 12:29 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 325 > > <https://reviews.apache.org/r/45717/diff/1/?file=1325272#file1325272line325> > > > > Do we need to check `pluginDir` here? I think in `recover()`, > > `pluginDir` will not be used, it should only be used in `attach` and > > `detach`. And in another hand, `rootDir` and `pluginDir` are always both > > set or both not set, it is not possible that we have one set but another > > not set, so I think checking one (`rootDir`) should be enough.
I guess we can simplify this check. Have gone ahead and removed check on `pluginDir`. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45717/#review126991 ----------------------------------------------------------- On April 4, 2016, 11:55 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45717/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:55 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5113 > https://issues.apache.org/jira/browse/MESOS-5113 > > > Repository: mesos > > > Description > ------- > > `rootDir` and `pluginDir` can be `None` in case the operator does not > specify the network cni flags. In this case invoking `recover` on the > isolator without checking the `rootDir` and `pluginDir` for `isSome` > will cause the Agent to crash. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > af5f49007e0afe57006c9db940611e56eb75a621 > > Diff: https://reviews.apache.org/r/45717/diff/ > > > Testing > ------- > > make > > Bought a slave and master and verified that the slave does not crash. > > > Thanks, > > Avinash sridharan > >
