----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45717/#review127058 -----------------------------------------------------------
Patch looks great! Reviews applied: [45717] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 5, 2016, 6:19 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45717/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 6:19 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-5113 > https://issues.apache.org/jira/browse/MESOS-5113 > > > Repository: mesos > > > Description > ------- > > `rootDir` and `pluginDir` can be `None` in case the operator does not > specify the network cni flags. In this case invoking `recover` on the > isolator without checking the `rootDir` and `pluginDir` for `isSome` > will cause the Agent to crash. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > af5f49007e0afe57006c9db940611e56eb75a621 > > Diff: https://reviews.apache.org/r/45717/diff/ > > > Testing > ------- > > make > > Bought a slave and master and verified that the slave does not crash. > > > Thanks, > > Avinash sridharan > >
