-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45731/#review127043
-----------------------------------------------------------




src/cli/execute.cpp (line 152)
<https://reviews.apache.org/r/45731/#comment190179>

    Should we mention that an image has to be provided && for mesos 
containerizer only?



src/cli/execute.cpp (line 187)
<https://reviews.apache.org/r/45731/#comment190178>

    Could you put it below `_dockerImage`? Thanks.



src/cli/execute.cpp (line 468)
<https://reviews.apache.org/r/45731/#comment190180>

    ditto.



src/cli/execute.cpp (line 612)
<https://reviews.apache.org/r/45731/#comment190182>

    ditto.


- Gilbert Song


On April 4, 2016, 10:39 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45731/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 10:39 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5117
>     https://issues.apache.org/jira/browse/MESOS-5117
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced '--networks' flag to mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/45731/diff/
> 
> 
> Testing
> -------
> 
> Ran the following command:
>   `sudo src/mesos-execute --master=192.168.122.171:5050 --name=test 
> --docker_image=library/busybox --command="sleep 30" --shell=true 
> --networks=net1,net2`
> 
> The created container successfully joined the CNI networks `net1` and `net2`.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to