> On April 5, 2016, 2:25 p.m., Gilbert Song wrote: > > src/cli/execute.cpp, line 187 > > <https://reviews.apache.org/r/45731/diff/1/?file=1325657#file1325657line187> > > > > Could you put it below `_dockerImage`? Thanks.
Can you please elaborate why we should put it below `_dockerImage`? The reason I put it below `_containerizer` is that I put the flag `Option<string> networks;` (L169) below `string containerizer;`, my idea was to keep them consistent in the code. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127043 ----------------------------------------------------------- On April 5, 2016, 1:39 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45731/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 1:39 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-5117 > https://issues.apache.org/jira/browse/MESOS-5117 > > > Repository: mesos > > > Description > ------- > > Introduced '--networks' flag to mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 > > Diff: https://reviews.apache.org/r/45731/diff/ > > > Testing > ------- > > Ran the following command: > `sudo src/mesos-execute --master=192.168.122.171:5050 --name=test > --docker_image=library/busybox --command="sleep 30" --shell=true > --networks=net1,net2` > > The created container successfully joined the CNI networks `net1` and `net2`. > > > Thanks, > > Qian Zhang > >
