-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45749/#review127165
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On April 5, 2016, 9:01 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45749/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 9:01 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Michael Park.
> 
> 
> Bugs: MESOS-5000
>     https://issues.apache.org/jira/browse/MESOS-5000
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This correctly reflects the lifetime dependencies among
> Master::storage, Master::state and Master::registrar.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768 
> 
> Diff: https://reviews.apache.org/r/45749/diff/
> 
> 
> Testing
> -------
> 
> Without this patch e.g., `MasterTest.MasterLost` fails under OS X with clang 
> (trunk, not optimized), and 
> `ResourceOffersTest.ResourceOfferWithMultipleSlaves` fails under Ubuntu14.04 
> with stock gcc (not optimized). With this patch they can be executed without 
> failure a couple thousand times.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to