----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127337 -----------------------------------------------------------
src/Makefile.am (line 2038) <https://reviews.apache.org/r/37168/#comment190622> How about make these sort by alphabetically? src/examples/dynamic_reservation_framework.cpp (line 46) <https://reviews.apache.org/r/37168/#comment190623> Why we need this as we have already `using namespace mesos`? src/examples/dynamic_reservation_framework.cpp (line 181) <https://reviews.apache.org/r/37168/#comment190639> How about add a default for unexpected state? May just log the error status. src/examples/dynamic_reservation_framework.cpp (line 295) <https://reviews.apache.org/r/37168/#comment190640> How about adjust the order of variable here? For example, enum defination comes first, then static variable, member variable. src/examples/dynamic_reservation_framework.cpp (line 366) <https://reviews.apache.org/r/37168/#comment190641> I think it would better to use ``` cerr << flags.usage('Missing --role') << endl; ``` - haosdent huang On April 6, 2016, 8:19 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 8:19 a.m.) > > > Review request for mesos, Greg Mann, Joerg Schad, and Michael Park. > > > Bugs: MESOS-3063 > https://issues.apache.org/jira/browse/MESOS-3063 > > > Repository: mesos > > > Description > ------- > > Provide example for dynamic reservation features. > > > Diffs > ----- > > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/examples/dynamic_reservation_framework.cpp PRE-CREATION > src/tests/dynamic_reservation_framework_test.sh PRE-CREATION > src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 > > Diff: https://reviews.apache.org/r/37168/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Klaus Ma > >
