----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/#review127581 -----------------------------------------------------------
Bad patch! Reviews applied: [45863] Failed command: ./support/apply-review.sh -n -r 45863 Error: 2016-04-07 11:28:15 URL:https://reviews.apache.org/r/45863/diff/raw/ [2452/2452] -> "45863.patch" [1] Total errors found: 0 Checking 1 files Error: No line in the commit message summary may exceed 72 characters. Full log: https://builds.apache.org/job/mesos-reviewbot/12378/console - Mesos ReviewBot On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45863/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 10:50 a.m.) > > > Review request for mesos, Yongqiao Wang and Joerg Schad. > > > Repository: mesos > > > Description > ------- > > While writing log or error messages we adhere the following style: > * No period at the end (there are exceptions though, e.g., one is > when constructing request responses. > * When splitting a string over multiple lines, put a space at the > beginning of the following line in contrast to the end of the > previous line. > > > Diffs > ----- > > src/master/weights_handler.cpp e88bf2ab67ccadf35879b92f3280298a43d7cd0e > > Diff: https://reviews.apache.org/r/45863/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > `make check` > > > Thanks, > > Alexander Rukletsov > >
