-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45863/#review128057
-----------------------------------------------------------


Fix it, then Ship it!





src/master/weights_handler.cpp (line 104)
<https://reviews.apache.org/r/45863/#comment191446>

    Mesos operator can update weight for mutilple roles at one time, so it is 
better to show which role's weight is not positive to make this error message 
more clearly.


- Yongqiao Wang


On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45863/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 10:50 a.m.)
> 
> 
> Review request for mesos, Yongqiao Wang and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While writing log or error messages we adhere the following style:
>   * No period at the end (there are exceptions though, e.g., one is
>     when constructing request responses.
>   * When splitting a string over multiple lines, put a space at the
>     beginning of the following line in contrast to the end of the
>     previous line.
> 
> 
> Diffs
> -----
> 
>   src/master/weights_handler.cpp e88bf2ab67ccadf35879b92f3280298a43d7cd0e 
> 
> Diff: https://reviews.apache.org/r/45863/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4: 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to