-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43524/#review127775
-----------------------------------------------------------


Fix it, then Ship it!




Could you please update the description? As a start, you can use the comment 
you left on JIRA about hardcoded values in the replicated log.

Also, please tun this test in repetition.


src/tests/log_tests.cpp (lines 1877 - 1878)
<https://reviews.apache.org/r/43524/#comment191166>

    Does it make sense to move this line up right after advancing the clock?


- Alexander Rukletsov


On Feb. 12, 2016, 2:47 p.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43524/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 2:47 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-4160
>     https://issues.apache.org/jira/browse/MESOS-4160
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speeded up RecoverTest.AutoInitialization by advacing the clock.
> 
> 
> Diffs
> -----
> 
>   src/tests/log_tests.cpp 923d71f48e743a77f2a3ba9e982aef4417c6c7fe 
> 
> Diff: https://reviews.apache.org/r/43524/diff/
> 
> 
> Testing
> -------
> 
> `$ sudo make check -j2 GTEST_FILTER='RecoverTest.AutoInitialization'`
> 
> ```sh
> [----------] 1 test from RecoverTest
> [ RUN      ] RecoverTest.AutoInitialization
> [       OK ] RecoverTest.AutoInitialization (630 ms)
> [----------] 1 test from RecoverTest (631 ms total)
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Reply via email to